Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-up create-turbo. #6439

Merged
merged 36 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
b708ab6
Re-up create-turbo.
anthonyshew Nov 14, 2023
b42154d
Minor cleanups.
anthonyshew Nov 14, 2023
cb46cbe
Remove unneeded tsconfig.
anthonyshew Nov 14, 2023
93f094c
feat(create-turbo): apply official-starter transform
turbobot-temp Nov 14, 2023
fa42f3a
feat(create-turbo): apply pnpm-eslint transform
turbobot-temp Nov 14, 2023
e5fc3fa
Instructions in create-turbo README.
anthonyshew Nov 14, 2023
8429a01
Pretty close, I think.
anthonyshew Nov 15, 2023
a2fb3f5
Very close...
anthonyshew Nov 15, 2023
855e365
Working.
anthonyshew Nov 15, 2023
3118dfe
Just have to get Next recommended to come through...
anthonyshew Nov 15, 2023
1bb32cb
Think we got it.
anthonyshew Nov 15, 2023
954ab4e
Remove incremental.
anthonyshew Nov 15, 2023
d14a6f6
Merge branch 'main' into update-create-turbo
anthonyshew Nov 15, 2023
9e075bd
Remove topo.
anthonyshew Nov 15, 2023
61e9b13
Tremendous.
anthonyshew Nov 15, 2023
c6b3970
Back to NodeNext.
anthonyshew Nov 15, 2023
21f78cd
Merge branch 'main' into update-create-turbo
anthonyshew Nov 15, 2023
2d35e90
Merge branch 'update-create-turbo' of https://github.com/vercel/turbo…
anthonyshew Nov 15, 2023
46e0bb0
Um...spooky.
anthonyshew Nov 16, 2023
ce3297b
Back to not touching this example.
anthonyshew Nov 16, 2023
0778410
Explicit node exports for better editor auto-importing.
anthonyshew Nov 16, 2023
c35b194
Merge branch 'main' into update-create-turbo
anthonyshew Nov 16, 2023
1505131
Bump docs node version to get CI green.
anthonyshew Nov 16, 2023
62164c2
Merge branch 'main' into update-create-turbo
anthonyshew Nov 16, 2023
9b15fc9
Merge branch 'update-create-turbo' of https://github.com/vercel/turbo…
anthonyshew Nov 16, 2023
302aaf7
Remove require.resolves.
anthonyshew Nov 16, 2023
77cbfc0
Use Workspace Configurations.
anthonyshew Nov 16, 2023
1548f8b
Lint generators.
anthonyshew Nov 16, 2023
a000269
Fix nonmonorepo example.
anthonyshew Nov 16, 2023
8fd0564
Update test snapshots.
anthonyshew Nov 16, 2023
9971597
Remove typecheck command.
anthonyshew Nov 17, 2023
d1bb221
Bring back meta.json.
anthonyshew Nov 17, 2023
ac2dce7
Move to transpilePackages.
anthonyshew Nov 20, 2023
83397be
Fix test?
anthonyshew Nov 20, 2023
ffc2097
Drop the run, it's cleaner.
anthonyshew Nov 20, 2023
c96850c
Remove random licenses.
anthonyshew Nov 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions examples/basic/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// This configuration only applies to the package manager root.
/** @type {import("eslint").Linter.Config} */
module.exports = {
ignorePatterns: ["apps/**", "packages/**"],
extends: ["@repo/eslint-config/library.js"],
parser: "@typescript-eslint/parser",
parserOptions: {
project: true,
},
};
anthonyshew marked this conversation as resolved.
Show resolved Hide resolved
40 changes: 21 additions & 19 deletions examples/basic/.gitignore
Original file line number Diff line number Diff line change
@@ -1,36 +1,38 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
# Dependencies
node_modules
.pnp
.pnp.js

# testing
# Local env files
.env
.env.local
.env.development.local
.env.test.local
.env.production.local

# Testing
coverage

# next.js
# Turbo
.turbo

# Vercel
.vercel

# Build Outputs
.next/
out/
build
dist

# misc
.DS_Store
*.pem

# debug
# Debug
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# local env files
.env
.env.local
.env.development.local
.env.test.local
.env.production.local

# turbo
.turbo

# vercel
.vercel
# Misc
.DS_Store
*.pem
8 changes: 7 additions & 1 deletion examples/basic/apps/docs/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
/** @type {import("eslint").Linter.Config} */
module.exports = {
extends: ["custom/next"],
root: true,
extends: ["@repo/eslint-config/next.js"],
parser: "@typescript-eslint/parser",
parserOptions: {
project: true,
},
};
34 changes: 0 additions & 34 deletions examples/basic/apps/docs/.gitignore

This file was deleted.

5 changes: 3 additions & 2 deletions examples/basic/apps/docs/app/page.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Image from "next/image";
import { Card } from "ui";
import { Card } from "@repo/ui/card";
import { Code } from "@repo/ui/code";
import styles from "./page.module.css";

function Gradient({
Expand Down Expand Up @@ -55,7 +56,7 @@ export default function Page(): JSX.Element {
<div className={styles.description}>
<p>
examples/basic&nbsp;
<code className={styles.code}>docs</code>
<Code className={styles.code}>docs</Code>
</p>
<div>
<a
Expand Down
2 changes: 1 addition & 1 deletion examples/basic/apps/docs/next.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/** @type {import('next').NextConfig} */
module.exports = {
reactStrictMode: true,
transpilePackages: ["ui"],
anthonyshew marked this conversation as resolved.
Show resolved Hide resolved
};
17 changes: 10 additions & 7 deletions examples/basic/apps/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,24 @@
"dev": "next dev --port 3001",
"build": "next build",
"start": "next start",
"lint": "next lint"
"lint": "eslint . --max-warnings 0",
"typecheck": "tsc --noEmit"
},
"dependencies": {
"next": "^13.4.19",
"@repo/ui": "workspace:*",
"next": "^14.0.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"ui": "workspace:*"
"react-dom": "^18.2.0"
},
"devDependencies": {
"@next/eslint-plugin-next": "^13.4.19",
"@next/eslint-plugin-next": "^14.0.2",
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"@types/eslint": "^8.44.7",
"@types/node": "^17.0.12",
"@types/react": "^18.0.22",
"@types/react-dom": "^18.0.7",
"eslint-config-custom": "workspace:*",
"tsconfig": "workspace:*",
"eslint": "^8.53.0",
"typescript": "^5.2.2"
}
}
16 changes: 13 additions & 3 deletions examples/basic/apps/docs/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
{
"extends": "tsconfig/nextjs.json",
"extends": "@repo/typescript-config/nextjs.json",
"compilerOptions": {
"plugins": [{ "name": "next" }]
"plugins": [
{
"name": "next"
}
]
},
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts"],
"include": [
"next-env.d.ts",
"next.config.js",
"**/*.ts",
"**/*.tsx",
".next/types/**/*.ts"
],
"exclude": ["node_modules"]
}
8 changes: 7 additions & 1 deletion examples/basic/apps/web/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
/** @type {import("eslint").Linter.Config} */
module.exports = {
extends: ["custom/next"],
root: true,
extends: ["@repo/eslint-config/next.js"],
parser: "@typescript-eslint/parser",
parserOptions: {
project: true,
},
};
5 changes: 3 additions & 2 deletions examples/basic/apps/web/app/page.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Image from "next/image";
import { Card } from "ui";
import { Card } from "@repo/ui/card";
import { Code } from "@repo/ui/code";
import styles from "./page.module.css";

function Gradient({
Expand Down Expand Up @@ -55,7 +56,7 @@ export default function Page(): JSX.Element {
<div className={styles.description}>
<p>
examples/basic&nbsp;
<code className={styles.code}>web</code>
<Code className={styles.code}>web</Code>
</p>
<div>
<a
Expand Down
2 changes: 1 addition & 1 deletion examples/basic/apps/web/next.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/** @type {import('next').NextConfig} */
module.exports = {
reactStrictMode: true,
transpilePackages: ["ui"],
};
15 changes: 9 additions & 6 deletions examples/basic/apps/web/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,24 @@
"dev": "next dev",
"build": "next build",
"start": "next start",
"lint": "next lint"
"lint": "eslint . --max-warnings 0",
"typecheck": "tsc --noEmit"
},
"dependencies": {
"next": "^13.4.19",
"next": "^14.0.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"ui": "workspace:*"
"@repo/ui": "workspace:*"
},
"devDependencies": {
"@next/eslint-plugin-next": "^13.4.19",
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"@next/eslint-plugin-next": "^14.0.2",
"@types/eslint": "^8.44.7",
"@types/node": "^17.0.12",
"@types/react": "^18.0.22",
"@types/react-dom": "^18.0.7",
"eslint-config-custom": "workspace:*",
"tsconfig": "workspace:*",
"eslint": "^8.53.0",
"typescript": "^5.2.2"
}
}
16 changes: 13 additions & 3 deletions examples/basic/apps/web/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
{
"extends": "tsconfig/nextjs.json",
"extends": "@repo/typescript-config/nextjs.json",
"compilerOptions": {
"plugins": [{ "name": "next" }]
"plugins": [
{
"name": "next"
}
]
},
"include": ["next-env.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts"],
"include": [
"next-env.d.ts",
"next.config.js",
"**/*.ts",
"**/*.tsx",
".next/types/**/*.ts"
],
"exclude": ["node_modules"]
}
7 changes: 0 additions & 7 deletions examples/basic/meta.json

This file was deleted.

16 changes: 9 additions & 7 deletions examples/basic/package.json
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
{
"name": "my-turborepo",
"private": true,
"scripts": {
"build": "turbo run build",
"dev": "turbo run dev",
"lint": "turbo run lint",
"build": "turbo build",
"dev": "turbo dev",
"lint": "turbo lint",
"typecheck": "turbo typecheck",
anthonyshew marked this conversation as resolved.
Show resolved Hide resolved
"format": "prettier --write \"**/*.{ts,tsx,md}\""
},
"devDependencies": {
"eslint": "^8.48.0",
"prettier": "^3.0.3",
"tsconfig": "workspace:*",
"turbo": "^1.10.16"
"@repo/eslint-config": "workspace:*",
"@repo/typescript-config": "workspace:*",
"prettier": "^3.1.0",
"turbo": "latest"
},
"packageManager": "[email protected]"
}
34 changes: 0 additions & 34 deletions examples/basic/packages/eslint-config-custom/library.js

This file was deleted.

42 changes: 0 additions & 42 deletions examples/basic/packages/eslint-config-custom/next.js

This file was deleted.

Loading
Loading