🔧 Foundry project maintenance and NatSpec #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neodaoist
commented
Nov 18, 2022
•
neodaoist
commented
- Update forge-std to v1.0.0
- Use forge-std IERC20 for tests (any gas changes on tests should be strictly due to changing where we get IERC20 from)
- Remove unused libs — ds-test, chainlink
- Remove python tooling
- Update remappings
- Add credit on OZ interfaces and pin pragma to 0.8.11
- Add some missing NatSpec, standardize formatting
- Add encodeTokenId() and decodeTokenId() to interface
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 87.20% 87.20%
=======================================
Files 2 2
Lines 344 344
Branches 52 52
=======================================
Hits 300 300
Misses 33 33
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
neodaoist
changed the title
0xAlcibiades
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.