Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why are double underscores not allowed? #510

Closed
woverton opened this issue Feb 26, 2016 · 2 comments
Closed

Why are double underscores not allowed? #510

woverton opened this issue Feb 26, 2016 · 2 comments

Comments

@woverton
Copy link

https://github.com/woverton/validator.js/blob/master/test/validators.js#L271

Is there any reason you do not allow double underscores? I cant find any references from googling that say this is not allowed.
@chriso
Copy link
Collaborator

chriso commented Feb 27, 2016

No reason! I think it's probably similar to #500 in that we added support for underscores in hostnames but were restrictive about it. If more than one underscore is valid then I'll lift the restriction.

@woverton
Copy link
Author

It looks like its valid 👍

@chriso chriso closed this as completed in a1c8dab Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriso @woverton