Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope of phone validation #2234

Open
karladler opened this issue Jun 14, 2023 · 1 comment
Open

Scope of phone validation #2234

karladler opened this issue Jun 14, 2023 · 1 comment

Comments

@karladler
Copy link

Question / Bug
Is the isMobilePhone function intended to only validate mobile phone numbers or should it actually also be possible for landlines? If yes, I would rewrite this as a bug, since some german landline numbers would not validate.

Examples
+4935178686876

Suggestion

  • Phone validation is in general a well discussed topic and really hard to do. Covering all countries and edge cases would also increase the package size a lot. It might be good, for the sake of this module, to completely outsource it to external packages like awesome-phonenumber. Tree shaking should do the rest.
@WikiRik
Copy link
Member

WikiRik commented Jun 14, 2023

It should only validate mobile phone numbers, but I know that there is some improvement to be done on that front. See also #2124

Outsourcing has not been discussed recently as far as I know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants