Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve link focus states #85

Closed
colinkiama opened this issue Jun 26, 2022 · 0 comments · Fixed by #120
Closed

Improve link focus states #85

colinkiama opened this issue Jun 26, 2022 · 0 comments · Fixed by #120
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@colinkiama
Copy link
Member

colinkiama commented Jun 26, 2022 •
edited
Loading

When using keyboard navigation, the experience isn't very good. Especially when using the dark colour scheme.

Currently either a very thin focus border shows up. In the dark colour scheme, the focus border blends in with the dark background.

The focus states should match the link hover states.
@colinkiama colinkiama added the enhancement New feature or request label Jun 26, 2022
@colinkiama colinkiama added the good first issue Good for newcomers label Jun 26, 2022
@colinkiama colinkiama mentioned this issue Jun 26, 2022
Closed
@colinkiama colinkiama linked a pull request Jun 30, 2022 that will close this issue
85 improve link focus states #120
Merged
@colinkiama colinkiama mentioned this issue Jun 30, 2022
Merged
Repository owner moved this from Todo to Done in Vala Website v1 Launch Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

85 improve link focus states vala-lang/vala-www
1 participant
@colinkiama