Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Metadata #160

Open
simasch opened this issue May 26, 2024 · 4 comments
Open

Duplicate Metadata #160

simasch opened this issue May 26, 2024 · 4 comments
Labels

Comments

@simasch
Copy link

simasch commented May 26, 2024

The metadata for Quarkus is duplicated, and this causes to display the Vaadin extension in the Dev UI twice.

Both JARs contain the metadata:

com.vaadin:vaadin-quarkus-extension::jar:24.3.12
com.vaadin:vaadin-quarkus::jar:2.0.1

See quarkusio/quarkus#40701

@mcollovati
Copy link
Contributor

Hi, thanks for reporting!

Actually, vaadin-quarkus-extension is a repackage of vaadin-quarkus with the addition of common Vaadin dependencies (e.g. vaadin-core) .

I am not sure if we will be able to "hide" one of the extension, but at list the name and description of vaadin-quarkus-extension could be changed to make it more evident that it is targeting Vaadin platform and not only Flow.

@simasch
Copy link
Author

simasch commented May 27, 2024

I don't understand why those are two extensions. There is only one, according to the directory.

@mcollovati
Copy link
Contributor

mcollovati commented May 27, 2024

In the directory, only vaadin-quarkus-extension is registered.
The artifact depends on vaadin-quarkus and adds some additional dependencies and Quarkus code starts, but it has basically no Java stuff inside.
So a project including vaadin-quarkus-extension is actually using both extensions.

@Dudeplayz
Copy link

Maybe adding the "unlisted" metadata to one of the quarkus-extension.yml helps. Couldn't find this documented, but quarkus is using it when reusing shared extensions.
An example: https://github.com/quarkusio/quarkus/blob/main/extensions/elytron-security-common/runtime/src/main/resources/META-INF/quarkus-extension.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔖 Low Priority (P3)
Development

No branches or pull requests

4 participants