Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split traits into: rpc, control, peripheral-traits #168

Open
rrbutani opened this issue Jul 25, 2022 · 0 comments
Open

Split traits into: rpc, control, peripheral-traits #168

rrbutani opened this issue Jul 25, 2022 · 0 comments
Assignees
Labels
➕ improvement Chores and fixes: the small things. P-low Low priority

Comments

@rrbutani
Copy link
Member

what

lc3-traits has grown pretty large; unlike all of our other crates it's hard to describe exactly what it does, concisely. I think it's time to split it up into:

  • lc3-peripheral-traits: traits/src/peripherals/*, traits/src/memory.rs, traits/src/control/metadata.rs, and traits/src/error.rs
  • lc3-control: traits/src/control/*.rs
  • lc3-rpc: traits/src/control/rpc/*.rs

Alternatively we can just leave control where it is and just spin off rpc into it's own crate. This may make more sense.

steps

where

branch: imp/trait-crate-split

open questions

Haven't completely thought this through but I don't think coherence gets in our way here.

@rrbutani rrbutani added ➕ improvement Chores and fixes: the small things. P-low Low priority labels Jul 25, 2022
@rrbutani rrbutani self-assigned this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ improvement Chores and fixes: the small things. P-low Low priority
Projects
None yet
Development

No branches or pull requests

1 participant