Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract the only parameter #4991

Merged
merged 3 commits into from
Sep 10, 2024
Merged

abstract the only parameter #4991

merged 3 commits into from
Sep 10, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Sep 3, 2024

This pull request makes the following changes:

  • abstract the only parameter
  • fix the issue of only parameter for source
  • abstract the search fields
  • abstract the paging

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

Copy link

linear bot commented Sep 3, 2024

@Mh-Asmi Mh-Asmi requested a review from ushahidlee September 3, 2024 04:55
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and works well for the first level fields. Will need a clear test plan before it can go into QA though

@Mh-Asmi
Copy link
Contributor Author

Mh-Asmi commented Sep 6, 2024

@Mh-Asmi Mh-Asmi removed the request for review from ushahidlee September 10, 2024 09:21
@Mh-Asmi Mh-Asmi dismissed ushahidlee’s stale review September 10, 2024 09:22

the test plan is added

@Mh-Asmi Mh-Asmi merged commit 8060251 into develop Sep 10, 2024
4 checks passed
Copy link

sentry-io bot commented Sep 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Ushahidi\Core\Exception\NotFoundException: Post not found Ushahidi\Modules\V5\Http\Controllers\PostContro... View Issue
  • ‼️ TypeError: Return value of Ushahidi\Modules\V5\Actions\Post\Queries\FindPostByIdQuery::getFields() must be o... Ushahidi\Modules\V5\Http\Controllers\PostContro... View Issue
  • ‼️ TypeError: Return value of Ushahidi\Modules\V5\Actions\Post\Queries\FindPostByIdQuery::getFields() must be o... Ushahidi\Modules\V5\Http\Controllers\PostContro... View Issue
  • ‼️ Ushahidi\Core\Exception\NotFoundException: Post not found Ushahidi\Modules\V5\Http\Controllers\PostContro... View Issue

Did you find this useful? React with a 👍 or 👎

@Mh-Asmi Mh-Asmi deleted the USH-1387 branch September 19, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants