Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(media-all): only call media.get if there is an id #1409

Merged
merged 4 commits into from
Jan 10, 2020
Merged

Conversation

rowasc
Copy link
Contributor

@rowasc rowasc commented Jan 10, 2020

This pull request makes the following changes:

Testing checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@rowasc rowasc requested a review from Angamanga January 10, 2020 14:59
Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Angamanga Angamanga merged commit 1d1af8f into develop Jan 10, 2020
@Angamanga
Copy link
Collaborator

Angamanga commented Jan 16, 2020

@Obadha2 This fix has no issue so adding the QA-checklist here (is in Steve Buscemi and in production already):

  • Add a post to a survey with images, but leave the image-field empty (no image)
  • Save the post
  • Go to dataview and look at the post
  • The post should load without any 404-responses from the /media endpoint (you can check this in the inspector, 'network'-tab and filter on "media":
    Screenshot 2020-01-16 at 10 01 14
  • Select edit for this post
  • Still no 404-responses from the /media endpoint
  • Add an image
  • The image should load
  • Save the post
  • The image should load when viewing the post

@AmTryingMyBest
Copy link
Contributor

QA'd, passes. 👍

@tuxpiper tuxpiper deleted the media-all branch March 24, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants