Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Upgradeability Contract Examples #290

Closed
HCastano opened this issue Feb 23, 2023 · 2 comments · Fixed by #292
Closed

Improve Upgradeability Contract Examples #290

HCastano opened this issue Feb 23, 2023 · 2 comments · Fixed by #292
Assignees

Comments

@HCastano
Copy link
Contributor

HCastano commented Feb 23, 2023

The current examples of upgradeability and call forwarding are confusing, incomplete, and
and some cases misleading.

We should update these examples to show correct behaviour, and to guide contract
developers into using correct patterns.

List of examples that we should aim to provide:

Concepts we want to illustrate:

  • Storage collisions and corruption
  • Safe delegate calls
  • Effects and implications of different ink::env::CallFlags
### Tasks
- [x] `delegate_call` example
- [x] ~~A EIP-1967 based proxy~~ Achieved by `set_code_hash()`
@DoubleOTheven
Copy link
Contributor

DoubleOTheven commented May 26, 2023

This project in ink!ubator can elp here. They reference this issue in their application here.

@SkymanOne SkymanOne assigned SkymanOne and unassigned HCastano Aug 14, 2023
@SkymanOne
Copy link
Contributor

I'll move this to ink docs repo as we just need to document this properly

@SkymanOne SkymanOne transferred this issue from use-ink/ink Dec 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenZeppelin ↔ ink! Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants