Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: graphql@16 support #2130

Closed
adam-h opened this issue Dec 7, 2021 · 4 comments · Fixed by #2133
Closed

RFC: graphql@16 support #2130

adam-h opened this issue Dec 7, 2021 · 4 comments · Fixed by #2133
Labels
future 🔮 An enhancement or feature proposal that will be addressed after the next release

Comments

@adam-h
Copy link

adam-h commented Dec 7, 2021

Summary

graphql-js updated to v16 (16.0.1 as of writing) recently and there are a few, minor, breaking changes. Mostly around type tweaks.

Proposed Solution

Update graphql (peer)dependency to v16, and associated types/usage.

@adam-h adam-h added the future 🔮 An enhancement or feature proposal that will be addressed after the next release label Dec 7, 2021
@kitten
Copy link
Member

kitten commented Dec 7, 2021

Just checked, as expected no breaking changes, at least in our context. I've already seen the more "severe" changes when working on graphql-web-lite a while back, since that built off of [email protected] back then, but for urql's purposes we're mostly only seeing snapshot breakage from the lacking trailing newlines in printed queries.

I suppose, similarly anyone who'll upgrade to the releases that'll be triggered by #2133 with an upgrade to graphql@^16 shouldn't expect to see any breakage. That said, they did drop IE11 support, which I'll call out here so people will notice. That said, while urql transpiled explicitly to IE11-compatible code, we didn't test IE11 support any longer and that was mostly done for bundle size purposes.
In practice, we used to aim for IE11 support, but we can reevaluate this next year due to IE11 EOL. However, this wouldn't change the status quo of urql too much.

@jgoux
Copy link

jgoux commented Dec 10, 2021

I just upgraded and it seems like webpack 5 (used in the context of storybook) isn't able to correctly resolve the @urql/exchange-execute package when using [email protected] : #2139

@JoviDeCroock
Copy link
Collaborator

This will be fixed in 0no-co/babel-plugin-modular-graphql#4 @jgoux

@jgoux
Copy link

jgoux commented Dec 10, 2021

This will be fixed in kitten/babel-plugin-modular-graphql#4 @jgoux

You replied 28 sec after I posted, are you a wizard? 😂

Thanks @JoviDeCroock ! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future 🔮 An enhancement or feature proposal that will be addressed after the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants