Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:(issue_1069) Dont show [arguments] in usage when there are no arguments defined #2001

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Nov 1, 2024

What type of PR is this?

(REQUIRED)

  • cleanup
  • feature

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1069

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Updated existing tests

Release Notes

(REQUIRED)

[arguments...] wont be shown in usage if no arguments are defined for command

@dearchap dearchap requested a review from a team as a code owner November 1, 2024 22:05
examples_test.go Outdated Show resolved Hide resolved
args.go Outdated Show resolved Hide resolved
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also has the 4 unmerged commits from #2000?

@dearchap dearchap merged commit 0c4c199 into urfave:main Nov 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to avoid that '[arguments...]' been printed
3 participants