Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore internal build dir #1991

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

dearchap
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • cleanup

What this PR does / why we need it:

(REQUIRED)

Increase code coverage to beyond 90% for user facing code.

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)


@dearchap dearchap requested a review from a team as a code owner October 24, 2024 01:10
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@abitrolly
Copy link
Contributor

Looking at this internal/, maybe rename it into scripts/? Because internal/ doesn't really tell what the dir is for.

@dearchap
Copy link
Contributor Author

@abitrolly you want to make the change in a separate PR ? I don't have bandwidth to do this now

@dearchap dearchap merged commit 2071b59 into urfave:main Oct 24, 2024
13 checks passed
@abitrolly
Copy link
Contributor

@dearchap sure, here you go - #1992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants