Dont check required flags until command action is executed

[dearchap]

What type of PR is this?

(REQUIRED)

• feature

What this PR does / why we need it:

(REQUIRED)

Working towards making all the flags appear in any order in the cli

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Added a new test TestRequiredFlagDelayed

go test -run=TestRequiredFlagDelayed

Release Notes

(REQUIRED)

This allows users to access help without having to provide all required flags for each of the commands

[Juneezee]

We can reduce some typings here by using table-driven test style like the TestFlagDuplicates below. What do you think?

cli/command_test.go

Lines 2971 to 2995 in 31c5c84

	func TestFlagDuplicates(t *testing.T) {
	tests := []struct {
	name string
	args []string
	errExpected bool
	}{
	{
	name: "all args present once",
	args: []string{"foo", "--sflag", "hello", "--isflag", "1", "--isflag", "2", "--fsflag", "2.0", "--iflag", "10"},
	},
	{
	name: "duplicate non slice flag(duplicatable)",
	args: []string{"foo", "--sflag", "hello", "--isflag", "1", "--isflag", "2", "--fsflag", "2.0", "--iflag", "10", "--iflag", "20"},
	},
	{
	name: "duplicate non slice flag(non duplicatable)",
	args: []string{"foo", "--sflag", "hello", "--isflag", "1", "--isflag", "2", "--fsflag", "2.0", "--iflag", "10", "--sflag", "trip"},
	errExpected: true,
	},
	{
	name: "duplicate slice flag(non duplicatable)",
	args: []string{"foo", "--sflag", "hello", "--isflag", "1", "--isflag", "2", "--fsflag", "2.0", "--fsflag", "3.0", "--iflag", "10"},
	errExpected: true,
	},
	}

[Juneezee]

👍