fix(bool-with-inverse-flag): fix string printing of bool with inverse flag to properly show inverse prefix #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dearchap
reviewed
Aug 17, 2024
dearchap
reviewed
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
BoolWithInverseFlagwas confusing as it was outputting the same description for both the positive and negative flags. This PR makes the usage a bit more clear by only printing out one usage description and printing the inverse prefix in brackets.Which issue(s) this PR fixes:
This PR fixes #1883.
Special notes for your reviewer:
FlagStringerand manipulating its output to match what we want. Let me know if you'd like to use a different approach here however!Testing
Release Notes