Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add File() #1945

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Add File() #1945

merged 3 commits into from
Jul 7, 2024
+12 −4

Conversation

6543
Copy link
Contributor

@6543 6543 commented Jul 5, 2024

similar to EnvVar()

It's just a smal helper to make NewValueSourceChain more usefull :)

@6543
Add File()
a11a8ad 
similar to EnvVar()
@6543 6543 requested a review from a team as a code owner July 5, 2024 23:19
@6543 6543 mentioned this pull request Jul 5, 2024
Merged
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Jul 6, 2024
@6543
make urfave/cli#1945 afailable
bbeae1c
@6543 6543 force-pushed the File_ValueSource branch from edea41e to bb1b3a9 Compare July 6, 2024 01:26
@6543
Copy link
Contributor Author

6543 commented Jul 6, 2024

will be used in woodpecker-ci/woodpecker#2951 ...

@abitrolly abitrolly mentioned this pull request Jul 6, 2024
Open
21 tasks
bartekpacia
bartekpacia approved these changes Jul 6, 2024
View reviewed changes
Copy link
Member

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but I'm holding off for more maintainers to speak up :)

Juneezee
Juneezee approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and LGTM

@abennett abennett merged commit 6d6416e into urfave:main Jul 7, 2024
13 checks passed
@6543 6543 deleted the File_ValueSource branch July 8, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekpacia bartekpacia bartekpacia approved these changes

@Juneezee Juneezee Juneezee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @Juneezee @bartekpacia @abennett