Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for path with brackets () #677

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

Amber-372
Copy link
Contributor

@Amber-372 Amber-372 commented Aug 14, 2023

Description

Directory with special characters does not work correctly
eg: project in path: E:\xxx\Code(Template)
withing the spacial characters '()' . auto import failed and then project worked fail.

It's a upgrade about fast-glob.
https://github.com/mrmlnc/fast-glob#why-are-parentheses-match-wrong

Linked Issues

Additional context

@Amber-372 Amber-372 requested a review from antfu as a code owner August 14, 2023 03:19
@Amber-372 Amber-372 changed the title add support for path width brackets () feat: add support for path with brackets () Aug 14, 2023
@sxzz sxzz requested a review from nabaonan as a code owner August 30, 2023 13:50
@Amber-372
Copy link
Contributor Author

Amber-372 commented Sep 13, 2023

@nabaonan Sorry, I'm not very familiar with the source code. Count you add this feature to the master version where appropriate?And this merger will be inessential.

It's a upgrade about fast-glob.
https://github.com/mrmlnc/fast-glob#why-are-parentheses-match-wrong

@antfu antfu merged commit 232a0f4 into unplugin:main Sep 14, 2023
1 of 8 checks passed
@antfu
Copy link
Member

antfu commented Sep 14, 2023

This seems to break the test, I have reverted it temporarily. Feel free to bring it back when you find the fix. Thanks

@machinesily
Copy link

Any Update? I need this merage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants