-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CornerRadius support to more default styles to match UWP #2713
Added CornerRadius support to more default styles to match UWP #2713
Conversation
Seems I accidentally also did Format Document on the |
In Generic.xaml it's best if you do. It'll be easier to track modifications when we'll migrate to a later version of WinUI |
74704c7
to
e83f726
Compare
Done :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update release notes
Fixed, I force push'd them away 😀 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Yes, that seems wrong, can you please create an issue (bug) for this? |
Looks like something @carldebilly may be interested in :) |
sure thing |
GitHub Issue (If applicable): #2710
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Noticed some other control styles were missing
CornerRadius
handling, too.What is the new behavior?
The following controls now respect
CornerRadius
:Button
ToggleButton
HyperlinkButton
RadioButton
ScrollViewer
ListView
GridView
ListViewHeaderItem
GridViewHeaderItem
ListViewItem
GridViewItem
ProgressBar
ProgressRing
ToggleSwitch
FlipViewItem
Frame
ComboBoxItem
TextBox
PasswordBox
ComboBox
support was added in #2711PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.