Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CornerRadius support to more default styles to match UWP #2713

Merged

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Mar 1, 2020

GitHub Issue (If applicable): #2710

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Noticed some other control styles were missing CornerRadius handling, too.

What is the new behavior?

The following controls now respect CornerRadius:

  • Button
  • ToggleButton
  • HyperlinkButton
  • RadioButton
  • ScrollViewer
  • ListView
  • GridView
  • ListViewHeaderItem
  • GridViewHeaderItem
  • ListViewItem
  • GridViewItem
  • ProgressBar
  • ProgressRing
  • ToggleSwitch
  • FlipViewItem
  • Frame
  • ComboBoxItem
  • TextBox
  • PasswordBox

ComboBox support was added in #2711

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@gitpod-io
Copy link

gitpod-io bot commented Mar 1, 2020

@MartinZikmund
Copy link
Member Author

Seems I accidentally also did Format Document on the Generic.xaml should I reset and redo the CornerRadius changes, or is it ok?

@jeromelaban
Copy link
Member

In Generic.xaml it's best if you do. It'll be easier to track modifications when we'll migrate to a later version of WinUI

@MartinZikmund MartinZikmund force-pushed the dev/mazi/corner-radius-more branch from 74704c7 to e83f726 Compare March 2, 2020 07:31
@MartinZikmund
Copy link
Member Author

In Generic.xaml it's best if you do. It'll be easier to track modifications when we'll migrate to a later version of WinUI

Done :-)

Copy link
Contributor

@davidjohnoliver davidjohnoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update release notes

@MartinZikmund
Copy link
Member Author

Update release notes

Fixed, I force push'd them away 😀

@MartinZikmund MartinZikmund added the ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met label Mar 2, 2020
@agneszitte
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mergify mergify bot merged commit 249d2cd into unoplatform:master Mar 2, 2020
@danielkornev
Copy link

danielkornev commented May 5, 2020

A question:

image

This is how WASM renders TextBox with Corner Radius. Why is there black thing behind the area that's cut by the corners?

and when user clicks on it it becomes white:

image

I suspect cornerradius isn't correctly cutting the corners as it is expected?

@MartinZikmund
Copy link
Member Author

Yes, that seems wrong, can you please create an issue (bug) for this?

@jeromelaban
Copy link
Member

Looks like something @carldebilly may be interested in :)

@danielkornev
Copy link

sure thing
#3110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Automatically merge the PR once all '.mergify.yml' policies are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants