[WASM] batch attributes updates in Shape::UpdateRender #19048
Labels
area/performance 📈
Categorizes an issue or PR as relevant to performance
kind/enhancement
New feature or request
platform/wasm 🌐
Categorizes an issue or PR as relevant to the WebAssembly platform
project/shapes-brushes 🔶
Categorizes an issue or PR as relevant to shapes and brushes
What would you like to be added
can be bundled into a single specialized
[JSImport]
callWhy is this needed
performance, as we are making multiple js interop calls
For which platform
No response
Anything else we need to know?
avoid reusing SetStyle(string, primitive_type) or SetStyle(string, (string, primitive_type)[])
since passing string across cs-js isn't as performant compared to other primitive type
the some of 4mthods are also called by their respectives OnPropertyChanged
^ consider extra what to set and let the caller to set them // void UpdateXyz() --> (string key, string value) UpdateXyz()
^ or, check if we can omit the OnPropertyChanged update completely?
also replace any TSInteropMarshaller.InvokeJS down the line with [JSImport] call
^ like: OnFillBrushChanged>SetElementFill>InvokeJS
The text was updated successfully, but these errors were encountered: