Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for partial xaml parsing #1298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Xiaoy312
Copy link
Contributor

@Xiaoy312 Xiaoy312 commented Dec 2, 2024

GitHub Issue (If applicable): n/a

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)
  • Other... Please describe: test

What is the current behavior?

What is the new behavior?

Allow partial xaml with omitted closing tags to be parsed with XamlHelper in tests.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Tested the changes where applicable: skia
  • Updated the documentation as needed:
  • Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Associated with an issue (GitHub or internal)
  • Commits must be following the Conventional Commits specification.

@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20241201/partial-xaml branch 5 times, most recently from 13719b4 to a49b9bf Compare December 2, 2024 15:05
@Xiaoy312 Xiaoy312 force-pushed the dev/xygu/20241201/partial-xaml branch from a49b9bf to 96bcb90 Compare December 3, 2024 01:11
@unodevops
Copy link

⚠️⚠️ The build 149156 has failed on Uno Toolkit - CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants