Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ToDo][Settings Flyout] Wrong Value Checked by Default for Current Theme When Opening Settings Flyout #780

Open
1 task done
agneszitte opened this issue Jul 9, 2024 · 1 comment · May be fixed by #783
Open
1 task done
Assignees

Comments

@agneszitte
Copy link
Contributor

Current behavior

When opening the settings flyout, the wrong value is checked by default for the current theme. The displayed theme mode does not reflect the actual current theme of the app.

image
image

Expected behavior

The settings flyout should correctly display the current theme mode by having the appropriate current theme option (Light or Dark) checked by default.

How to reproduce it (as minimally and precisely as possible)

  • Open the application in Wide Layout.
  • Click on the "Get Started" button on the Welcome Page.
  • Click on the user name button in the top left corner of the app at the top of the menu to open the settings flyout.
  • Observe that the wrong value is checked by default for the current theme.
  • The displayed theme mode (Light or Dark) does not match the actual theme applied to the app.

Environment

Nuget Package:

  • Uno.Sdk: 5.2.161
  • UnoExtensionsVersion: 4.1.28
  • UnoToolkitVersion: 6.0.24
  • UnoThemesVersion: 5.0.13

Affected platform(s):

  • All (Seeing it less frequently on Windows than on other platforms, but it can also happen on Windows with the current logic in place).

Additional information

Possible related issue: #778

@agneszitte
Copy link
Contributor Author

agneszitte commented Jul 9, 2024

From #778

@rajamatt / @kazo0 The current logic will need to be reviewed:

ItemChecked="ThemeChipGroup_ItemChecked"

// Workaround for https://github.com/unoplatform/uno/issues/15287

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants