-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default
column value param
#1136
Conversation
looks like there are some mypy errors and unit test errors. Be sure to setup and run pre-commit and run unit tests to make sure things are running locally! |
taking a look now @kykyi! gonna help out with the conflicts |
Signed-off-by: kykyi <[email protected]>
Signed-off-by: kykyi <[email protected]>
Signed-off-by: kykyi <[email protected]>
Signed-off-by: kykyi <[email protected]>
…match Signed-off-by: kykyi <[email protected]>
…lasses and functions Signed-off-by: kykyi <[email protected]>
Signed-off-by: kykyi <[email protected]>
Signed-off-by: kykyi <[email protected]>
Signed-off-by: kykyi <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1136 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 65 65
Lines 4912 4916 +4
=======================================
+ Hits 4783 4787 +4
Misses 129 129
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Thanks @cosmicBboy 👌 🙌 Anything else needed on this PR now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Nope, ready to merge! thanks for the contribution @kykyi , and congrats on your first PR to pandera! |
Great thanks for all your help 😄😄 |
In relation to #502, this PR (and this fork) introduces a default value using
pandas.fillna()
! When buildingColumn
s in aDataFrameSchema
, you can add adefault
argument to fillNaN
s in dataframe being validated:This PR includes the updated code, tests to assert
default
works as expected, and adds docstrings in line with the rest of the codebase.TODO: