Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pretty printing for baked data #3482

Closed
Manishearth opened this issue Jun 5, 2023 · 1 comment · Fixed by #3491
Closed

Fix pretty printing for baked data #3482

Manishearth opened this issue Jun 5, 2023 · 1 comment · Fixed by #3491
Assignees
@Manishearth
Labels
A-data Area: Data coverage or quality S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Milestone
2.x Priority ⟨P2⟩

Comments

@Manishearth
Copy link
Member

rustfmt can't format macros and thus #3449 broke prettyprinting for baked data.

We should get it back.

Unfortunately this probably means avoiding the nice quote!() interpolation functions in the end and instead using format!(). I think it's not a huge deal.
@Manishearth Manishearth added T-techdebt Type: ICU4X code health and tech debt S-small Size: One afternoon (small bug fix or enhancement) A-data Area: Data coverage or quality labels Jun 5, 2023
@Manishearth Manishearth added this to the 1.x Priority ⟨P2⟩ milestone Jun 5, 2023
@Manishearth Manishearth self-assigned this Jun 5, 2023
This was referenced Jun 5, 2023
Merged
Closed
Merged
@Manishearth
Copy link
Member Author

#3491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manishearth Manishearth

Labels
A-data Area: Data coverage or quality S-small Size: One afternoon (small bug fix or enhancement) T-techdebt Type: ICU4X code health and tech debt
Projects
None yet
Milestone
2.x Priority ⟨P2⟩
1 participant
@Manishearth