Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

401 (Unauthorized) #328

Closed
chessl opened this issue May 15, 2019 · 8 comments
Closed

401 (Unauthorized) #328

chessl opened this issue May 15, 2019 · 8 comments

Comments

@chessl
Copy link

chessl commented May 15, 2019

image

It appears in the console every time when opening the demo page and my site has the same issue. I checked and the site_id matches.

@umputun
Copy link
Owner

umputun commented May 16, 2019

I think this is expected. UI is trying to determine if the user logged in or not. @Reeywhaar - pls confirm

@Reeywhaar
Copy link
Collaborator

Well, error handling should be there, this should be considered log spam.

@umputun
Copy link
Owner

umputun commented May 16, 2019

so, smth to address on your side?

@Reeywhaar
Copy link
Collaborator

yep, it's a minor bug

@Reeywhaar
Copy link
Collaborator

oh, sorry, I've mistaken this with console.error message, but this is just plain network request log and nothing can be done here, it's browser thing that @umputun have described.

@umputun
Copy link
Owner

umputun commented May 16, 2019

is it considered wrong/bad/annoying? Theoretically, we can address it by changing the response of /user call to return json with "status": "unauthorized", however, this feels odd to me because this is exactly what 401 supposes to represent

@Reeywhaar
Copy link
Collaborator

I think this clearly will be breaking change. Dunno, this kind of error pops on blink/webkit based browsers, why they have chosen to treat this as an error? In firefox you get this message if you turned on logging xhr requests in console which is not default.

@chessl
Copy link
Author

chessl commented May 16, 2019

Just found out a StackOverflow post addressing the same issue. It certainly is a chrome thing and I guess I'll just have to ignore it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants