Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <select> dropdowns and other native chrome. #70

Closed
adamjs opened this issue Dec 20, 2018 · 11 comments
Closed

Add support for <select> dropdowns and other native chrome. #70

adamjs opened this issue Dec 20, 2018 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@adamjs
Copy link
Member

adamjs commented Dec 20, 2018

Native dropdowns currently crash, should expose these for handling by user in a modal callback.

Also other native chrome is not rendering correctly yet (radio buttons / checkboxes), should add a default CSS theme override for these elements.

@adamjs adamjs added the bug Something isn't working label Dec 20, 2018
@adamjs adamjs self-assigned this Dec 20, 2018
@renaudfv
Copy link

What is the status on this?
I'm having trouble rendering select and radio buttons.
Also, does normal form item behaviour have to be taken for granted? Eg. clicking on a text input allows you to edit it, or do we have to implement it?

@m4heshd
Copy link

m4heshd commented Jan 4, 2020

I learned this when my project was almost done. Can't finish it without the the <select> functionality. So unfortunate. 😔

@adamjs
Copy link
Member Author

adamjs commented Jan 4, 2020

@m4heshd Native support for <select> tag is coming in the upcoming 1.2 branch but you should be able to use any JS replacement to draw/theme these elements.

Here's an example of using the Selectr script (plain JS/CSS) to replace all <select> elements on a page with themeable CSS widgets:

https://gist.github.com/adamjs/6e227ca4adc620742b3a3dab27bc38d8

select_example

@m4heshd
Copy link

m4heshd commented Jan 5, 2020

Hi @adamjs,
Thank you so much for the suggestion. I actually tried a few JS/CSS select elements. But decided to give up because they had some weird rendering issues in the Ultralight window. Same happens with your version. BTW yours look way more cleaner than the other ones I've tried. Take a look at this. It seems to be focusing every single sub element.

image

@adamjs
Copy link
Member Author

adamjs commented Jan 5, 2020

I think something funky is going on with focus ring painting in that example-- I'll throw it up in a debugger tomorrow and try to fix.

@m4heshd
Copy link

m4heshd commented Jan 5, 2020

Please do. Thanks. Also there's this issue. #228.

@adamjs
Copy link
Member Author

adamjs commented Jan 5, 2020

The focus ring issue should now be fixed in latest trunk.

@m4heshd
Copy link

m4heshd commented Jan 5, 2020

Thank you. It works on the x64 version now. Somehow i have this weird permission issue with the AppCore.dll from the x86 build. Can't do anything with that file. Build process also fails at the copying step because of this permission issue. All the x86 builds have this issue.

image

@adamjs
Copy link
Member Author

adamjs commented Jan 5, 2020

@m4heshd You're using the CMake script from the quick-start repo to pull down latest deps? Try deleting your build folder manually and rebuild (may need to do it as Administrator), Windows may have locked that file.

@m4heshd
Copy link

m4heshd commented Jan 5, 2020

Tried it. Doesn't work with elevated privileges either. Tried manual download, CLI, Winrar everything. x64 build works with no issue. I'm thinking this might be a UAC issue but why for that one specific file?

@adamjs
Copy link
Member Author

adamjs commented Jul 4, 2020

Support for dropdowns, progress bars, and range sliders is now available in current trunk.

@adamjs adamjs closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants