Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inline code formatting not applied consistently with backticks #4467

Closed
1 of 2 tasks
marwan37 opened this issue Sep 21, 2023 · 1 comment
Closed
1 of 2 tasks
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@marwan37
Copy link
Contributor

Which packages did you experience the bug in?

extension-code

What Tiptap version are you using?

2.2.0-rc.3

What’s the bug you are facing?

This issue was originally identified in the BlockNote project. For additional context and discussions, see Issue #338 in BlockNote.

When using backticks to format inline code, the expected behavior is that any text enclosed between two backticks should be formatted as inline code, regardless of the surrounding characters. However, the current implementation in TipTap does not consistently apply this formatting, especially when the backticks are surrounded by characters like parentheses, brackets, or other punctuation marks.

Issue can be replicated from the TipTap playground for the Code extension:
TipTapPlayground-Code

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

I expected that any text enclosed between two backticks, irrespective of surrounding characters, would be consistently formatted as inline code. This behavior should be uniform across different contexts and scenarios.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@marwan37 marwan37 added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Sep 21, 2023
@github-project-automation github-project-automation bot moved this to Triage open in Tiptap Sep 21, 2023
@nperez0111
Copy link
Contributor

v2.10.3 resolves this

@github-project-automation github-project-automation bot moved this from Triage open to Done in Tiptap Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants