Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: unsetBlockquote causes listItems to be lifted instead of blockquote #4434

Open
1 of 2 tasks
Nantris opened this issue Sep 9, 2023 · 3 comments
Open
1 of 2 tasks
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug

Comments

@Nantris
Copy link
Contributor

Nantris commented Sep 9, 2023

Which packages did you experience the bug in?

core

What Tiptap version are you using?

2.1.8

What’s the bug you are facing?

This is reproducible if you use the underlying command commands.lift('blockquote') from inside of a list inside of a blockquote. The listItem will be lifted and the blockquote will remain.

What browser are you using?

Chrome

Code example

No response

What did you expect to happen?

Lift list out of blockquote, not lift paragraph out of listItem.

Anything to add? (optional)

I assume this must be a mistake in the underlying lift command, but that leverages ProseMirror so I'm not sure what the true root cause might be.

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@Nantris Nantris added Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug labels Sep 9, 2023
@github-project-automation github-project-automation bot moved this to Triage open in Tiptap Sep 9, 2023
@Nantris
Copy link
Contributor Author

Nantris commented Nov 9, 2023

Same with toggleBlockquote

The commands calls toggleWrap which then calls lift which lifts the nearest node, not the correct node.

I don't know how to fix this but I hope we can get some attention on this.

@Nantris
Copy link
Contributor Author

Nantris commented Nov 17, 2023

I've discovered this issue can not only unwrap lists unexpectedly, but for nested listItems it can remove their content from the editor entirely, whereas I'd expect it would simply do nothing. Can anyone from the core team comment on this? Is there a plan to fix the blockquote commands? They're the only basic commands that don't seem to work.

@Nantris
Copy link
Contributor Author

Nantris commented Nov 26, 2023

Friendly bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Type: Bug The issue or pullrequest is related to a bug
Projects
No open projects
Status: Triage open
Development

No branches or pull requests

3 participants