New permission types #585
New permission types #585
Conversation
Hanspagh
force-pushed
the
other-permission-types
branch
from
30b6c4f to
9318143
Compare
|
@Hanspagh I will look through this later today or tomorrow but I'm loving the refactoring so far! I'm all for improving the maintainability of the code. 🎉 |
|
Definitely, prefer to do the changes that would introduce breaking change as V2 |
|
I have now renamed the base permission module and added text and atom encoding modules. Fell free to have a look. |
|
Any feedback on this? |
|
@Hanspagh sorry, I wasn't aware if this was ready for code review or not. I will do some CR today. |
There was a problem hiding this comment.
@Hanspagh this is awesome seriously. I absolutely would love to see more refactors like this. The resulting code is so easy to read and walk through, the tests are focused and concise.
Two small syntax changes and this is 👍 from me.
|
@doomspork should we use This is the only thing that I would give feedbacks so far but I am not sure if that should be the case. |
|
@yordis only if it is multiple lines. I think trying to use |
|
I sorry for the long delay, I will fix the last requested changes today |
…ic in relevant modules
Hanspagh
force-pushed
the
other-permission-types
branch
from
cf51ecc to
e4781cd
Compare
|
Fixed the pipelines issues, bad habit of just putting everything in a pipe |
|
@Hanspagh travis is failing btw |
Hanspagh
force-pushed
the
other-permission-types
branch
from
5c28421 to
8768b4c
Compare
Hanspagh
force-pushed
the
other-permission-types
branch
from
40ee0b6 to
52ede25
Compare
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=========================================
+ Coverage 84.97% 85.68% +0.7%
=========================================
Files 17 20 +3
Lines 406 426 +20
=========================================
+ Hits 345 365 +20
Misses 61 61
Continue to review full report at Codecov.
|
|
Travis should be happy now |
|
Thank you @Hanspagh!! |
|
@yordis would you like to prep the next release? |
|
@doomspork Aye! Then I need to close ueberauth/guardian_phoenix#2 |
* update ex_doc to be able to generate docs * refactor bitwise_endcoding into own module * move validation back * move most logic back into bitwise, and keep decoding and encoding logic in relevant modules * dynamicly load modules * rename permission module and add text and atom encoders * dont use pipelines for singel functions * add simple module docs * fix behavoir types
I have started to refactor the bitwise permission into its own module. This will to allow other encodings like json, as suggest here #470
Currently it is very much work in progress, but as of now I have moved the bitwise encoding to its own module and all the old tests parses. Next task is to implement a json encoder and then make the interface simpler to make it easier for people to write their own encoders.
To avoid breaking changes I didn't change the module name from bitwise to permissions, but maybe it is something we should consider?