Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score module attempt validation does not include semester #1611

Open
clpetersonucf opened this issue Oct 1, 2024 · 0 comments
Open

Score module attempt validation does not include semester #1611

clpetersonucf opened this issue Oct 1, 2024 · 0 comments

Comments

@clpetersonucf
Copy link
Member

Attempt limits are specific to context ids and semesters: at least that's the idea. If I play a widget directly in Fall 2023, and then again in Spring 2024, those count against each semester's attempt limit, but fall 2023's attempt should not be deducted from spring 2024's attempt limit.

However, the score module appears to be ignoring semesters when validating the current attempt limit: https://github.com/ucfopen/Materia/blob/master/fuel/app/classes/materia/score/module.php#L99

This means that for a given context ID, multiple semesters' worth of attempts are being bundled together to count against the attempt limit. The student will be able to initialize the widget, but will be unable to complete it, as the server responds with a 403 to play_logs_save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant