Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Include exception message in UnexpectedError error frame #269

Open
prashantv opened this issue Oct 23, 2015 · 1 comment
Open

Include exception message in UnexpectedError error frame #269

prashantv opened this issue Oct 23, 2015 · 1 comment

Comments

@prashantv
Copy link

Right now, the error frame description does not include any information about what failed:
https://github.com/uber/tchannel-python/blob/master/tchannel/tornado/dispatch.py#L231

We should consider adding e.message to the error frame for more information

cc @jcorbin

@jc-fireball
Copy link
Contributor

Hard to tell whether want to pass the stack trace into the error message and send back to client. On one hand the exception message may disclosure some internal information from server which the server owner may not want to share it with all clients (like http internal server error). On the other hand by giving more error information, client can know more about what's happening.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants