-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable archival config per domain #1351
Merged
andrewjdawson2016
merged 26 commits into
cadence-workflow:master
from
andrewjdawson2016:ArcCfg
Dec 21, 2018
Merged
Enable archival config per domain #1351
andrewjdawson2016
merged 26 commits into
cadence-workflow:master
from
andrewjdawson2016:ArcCfg
Dec 21, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjdawson2016
force-pushed
the
ArcCfg
branch
from
December 21, 2018 06:41
74716a4
to
b292265
Compare
samarabbas
reviewed
Dec 21, 2018
30: optional string archivalBucketName | ||
40: optional i32 archivalRetentionPeriodInDays | ||
50: optional ArchivalStatus archivalStatus | ||
60: optional string archivalBucketOwner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to have a separate owner information for the bucket as part of domain configuration? This is more like bucket metadata and should belong to blob store.
samarabbas
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff Contains The Following
Concepts to Understand