Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for wildcards in ignore #644

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

eigenbrot
Copy link
Contributor

@eigenbrot eigenbrot commented Aug 2, 2024

Description

Fixes #642

The ignore config option now supports wildcard matching. Any wildcards understood by fnmatch are supported.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure test pass on your local environment.
  • Create a file in src/towncrier/newsfragments/. Briefly describe your
    changes, with information useful to end users. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@eigenbrot eigenbrot requested a review from a team as a code owner August 2, 2024 19:31
Comment on lines 481 to 482
extra_config='ignore = ["template.jinja", "star_wildcard*", "question_wildcard_?", '
'"seq_wildcard_[ab]"]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep it simple

Suggested change
extra_config='ignore = ["template.jinja", "star_wildcard*", "question_wildcard_?", '
'"seq_wildcard_[ab]"]',
extra_config='ignore = ["template.jinja", "star_wildcard*"]',

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks. Only minor comments.

Pleas check my feedback.

If you want to keep the tests as they are now, that's fine , and we can merge it.

Thanks again

@eigenbrot
Copy link
Contributor Author

Thanks for the comments, @adiroiban, I've updated the PR as you suggested.

@adiroiban adiroiban merged commit 0f1d802 into twisted:trunk Aug 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow wildcards in "ignore" configuration option
2 participants