-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for wildcards in ignore #644
Conversation
I.e., these are what we want to fix
This still captures exact matches (i.e., the previous behavior)
src/towncrier/test/test_check.py
Outdated
extra_config='ignore = ["template.jinja", "star_wildcard*", "question_wildcard_?", ' | ||
'"seq_wildcard_[ab]"]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to keep it simple
extra_config='ignore = ["template.jinja", "star_wildcard*", "question_wildcard_?", ' | |
'"seq_wildcard_[ab]"]', | |
extra_config='ignore = ["template.jinja", "star_wildcard*"]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Thanks. Only minor comments.
Pleas check my feedback.
If you want to keep the tests as they are now, that's fine , and we can merge it.
Thanks again
We can trust that `fnmatch` works the way it's supposed to.
Thanks for the comments, @adiroiban, I've updated the PR as you suggested. |
Description
Fixes #642
The
ignore
config option now supports wildcard matching. Any wildcards understood by fnmatch are supported.Checklist
src/towncrier/newsfragments/
. Briefly describe yourchanges, with information useful to end users. Your change will be included in the public release notes.
docs/tutorial.rst
is still up-to-date.docs/cli.rst
reflects those changes.docs/configuration.rst
reflects those changes.