Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Embedded workspace documents' option excludes files from processing (by their name) based on unclear rules. #350

Open
jurykor opened this issue Oct 17, 2024 · 4 comments

Comments

@jurykor
Copy link

jurykor commented Oct 17, 2024

Describe the bug
The 'Embedded workspace documents' option excludes files from processing (by their name) based on unclear rules.
There are no files like `.gitignore' in the folder.

To Reproduce

See behavior with original names original_names.mkv

Expected behavior

All files must be processed.
See the behavior after renaming renamed.mkv

Desktop (please complete the following information):

  • OS: windows, linux
  • vscode: 1.94.2
  • twinny: v3.17.28
@fishshi
Copy link
Collaborator

fishshi commented Nov 8, 2024

Hello, this issue should be resolved. Now, Twinny not only uses .gitignore to ignore files during embedding, but you can also add custom ignore items in the global settings.

@jurykor
Copy link
Author

jurykor commented Nov 8, 2024

Thanks! I have already tested the feature and it works as expected.
However, I would like to bring up one point for consideration. The .git directory is currently included in the indexing process by default. Would it be possible to add it to the embeddingIgnoredGlobs by default?

@fishshi
Copy link
Collaborator

fishshi commented Nov 8, 2024

In fact, this issue has been resolved in #375 and published in the latest 3.18.9 version. You may need to update your extension in VSCode.
Also, If the latest version still has this issue, please don't hesitate to let me know.

@jurykor
Copy link
Author

jurykor commented Nov 8, 2024

Yes, I had already typed a message, but you got there first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants