-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.bar-footer
stops getting bottom: 0
#395
Comments
Just looked at the minified code. Looks like the entire rule is just not there.
cc: @XhmikosR |
Can you try with this patch? Advanced optimizations might bite us in the ass again :P Gruntfile.js | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/Gruntfile.js b/Gruntfile.js
index 895e391..b0eb74c 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -83,6 +83,7 @@ module.exports = function(grunt) {
options: {
banner: '', // set to empty; see bellow
keepSpecialComments: '*', // set to '*' because we already add the banner in sass
+ noAdvanced: true, // disable advanced optimizations since it causes many issues
report: 'min'
},
ratchet: {
@@ -90,9 +91,6 @@ module.exports = function(grunt) {
dest: '<%= meta.distPath %><%= pkg.name %>.min.css'
},
docs: {
- options: {
- noAdvanced: true // disable advanced optimizations since it causes code highlighting not to work
- },
src: [
'<%= meta.docsAssetsPath %>css/docs.css',
'<%= meta.docsAssetsPath %>css/pygments-manni.css'
|
Also, @connors clean-css does selectors merging so are you sure the property isn't there? |
@XhmikosR Yep your patch worked! |
Not sure if I should be happy about it :P I'll push it for now; better be safe I guess :) |
Not sure what happened but for some reason
.bar-footer
has stopped gettingbottom: 0
.I haven't looked at it closely yet. It may only be in the docs.
Screen of the
.bar-footer
in the docs on the top instead of the bottom:The text was updated successfully, but these errors were encountered: