Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Form inside modal #40491

Closed
3 tasks done
lonix1 opened this issue May 26, 2024 · 1 comment
Closed
3 tasks done

[Docs] Form inside modal #40491

lonix1 opened this issue May 26, 2024 · 1 comment

Comments

@lonix1
Copy link

lonix1 commented May 26, 2024

Prerequisites

Describe the issue

One can have a form inside a modal. Docs are here.

But that example is incorrect because the submit button is outside the form.

I think this:

<div class="modal" ...>
  <div class="modal-dialog">
    <div class="modal-content">
      <div class="modal-header"><!-- ... --></div>
      <div class="modal-body"><form><!-- ... --></form></div>            <-----
      <div class="modal-footer"><!-- ... --></div>
    </div>
  </div>
</div>

should be like this:

<div class="modal" ...>
  <form class="modal-dialog">                                             <-----
    <div class="modal-content">
      <div class="modal-header"><!-- ... --></div>
      <div class="modal-body"><!-- ... --></div>
      <div class="modal-footer"><!-- ... --></div>
    </div>
  </form>
</div>

Reduced test cases

See above

What operating system(s) are you seeing the problem on?

n/a

What browser(s) are you seeing the problem on?

n/a

What version of Bootstrap are you using?

5.3

@mdo
Copy link
Member

mdo commented Jun 13, 2024

Not an issue, there's no explicit submit button there. You can mark it up like that, or you can replace any of the divs with a form element, but it's not necessary.

@mdo mdo closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2024
@github-project-automation github-project-automation bot moved this from Needs review to Done in v5.3.4 Jun 13, 2024
@julien-deramond julien-deramond removed this from v5.3.4 Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants