Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle mail export throttling #8118

Open
wants to merge 2 commits into
base: export-integration
Choose a base branch
from
Open

Handle mail export throttling #8118

wants to merge 2 commits into from

Conversation

BijinDev
Copy link
Contributor

issue #8109

@BijinDev BijinDev linked an issue Dec 11, 2024 that may be closed by this pull request
Handle server throttling mailbox export #8109
Open
charlag
charlag reviewed Dec 12, 2024
View reviewed changes
src/mail-app/native/main/MailExportController.ts Outdated
@@ -127,8 +126,19 @@ export class MailExportController {

private async runExport(mailboxDetail: MailboxDetail, mailBags: MailBag[], mailId: Id) {
for (const mailBag of mailBags) {
await this.exportMailBag(mailBag, mailId)
if (this._state().type !== "exporting") {
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean that if we get one of the errors the export aborts? I thought we would wait however long is necessary and then continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlag charlag charlag left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle server throttling mailbox export
2 participants
@BijinDev @charlag