-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add support for P2WPKh (Segwit) and P2TR key-path (Taproot) #3213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e multiple variants
24 tasks
Closing in favor of #3233 |
@RomanDariicuk Can you please stop it with those cryptic replies? Clarify what you want or are trying to say. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3178
Although testing and debugging for BRC20 are still in progress, we plan to add support for P2WPKH and P2TR key-path earlier. Personally, I'm not a fan of merging this prematurely. However, here's the current checklist:
The existing wallet-core library offers a lot of Bitcoin-related functionality such as fee estimation and message signing. We're retaining all of these for existing features in the iOS and Android apps (including traditional P2PKH Bitcoin transactions). Therefore, we're creating a separate C++ structure explicitly for Segwit/Taproot with similar APIs.
As for the code itself, several
TODO
's and unhandled.unwrap()
's remain in the non-FFI exposed code (i.e., in the Ordinals/BRC20 sections). Rust API itself is likely to change. Btw, based on what I saw in the iOS codebase, it seems we only support P2PKH and (sending to) P2WPKH transactions, while others like P2PK and P2SH are not supported. Since we have Taproot now I think there's no longer a need to consider those, anyway.