From 487e8f716dc63ecf993214f81cd48f9bd0cd6e18 Mon Sep 17 00:00:00 2001 From: Venkatesh N Date: Thu, 11 Jan 2024 10:50:46 +0530 Subject: [PATCH 1/3] Fixed uneven width on rowSelection and rowAction columns --- stencil-workspace/src/components/modus-table/modus-table.scss | 1 + .../src/components/modus-table/parts/modus-table-header.tsx | 2 +- .../parts/row/selection/modus-table-header-checkbox.tsx | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/stencil-workspace/src/components/modus-table/modus-table.scss b/stencil-workspace/src/components/modus-table/modus-table.scss index dbd2c683b..f94113ed9 100644 --- a/stencil-workspace/src/components/modus-table/modus-table.scss +++ b/stencil-workspace/src/components/modus-table/modus-table.scss @@ -31,6 +31,7 @@ table { font-size: $rem-14px; height: fit-content; width: 100%; + table-layout: fixed; &.cell-borderless { th, diff --git a/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx b/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx index cb74c5282..48840e033 100644 --- a/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx +++ b/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx @@ -56,7 +56,7 @@ export const ModusTableHeader: FunctionalComponent = ({ /> ); })} - {rowActions.length > 0 && } + {rowActions.length > 0 && } ))} diff --git a/stencil-workspace/src/components/modus-table/parts/row/selection/modus-table-header-checkbox.tsx b/stencil-workspace/src/components/modus-table/parts/row/selection/modus-table-header-checkbox.tsx index 4745d6388..6eff925e2 100644 --- a/stencil-workspace/src/components/modus-table/parts/row/selection/modus-table-header-checkbox.tsx +++ b/stencil-workspace/src/components/modus-table/parts/row/selection/modus-table-header-checkbox.tsx @@ -14,7 +14,7 @@ export const ModusTableHeaderCheckbox: FunctionalComponent + {rowSelectionOptions?.multiple && ( Date: Thu, 11 Jan 2024 14:48:17 +0530 Subject: [PATCH 2/3] Commented out unused variable --- .../src/components/modus-table/parts/modus-table-header.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx b/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx index 48840e033..cc49274ce 100644 --- a/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx +++ b/stencil-workspace/src/components/modus-table/parts/modus-table-header.tsx @@ -35,7 +35,7 @@ export const ModusTableHeader: FunctionalComponent = ({ const tableHeadClass = { 'show-resize-cursor': getColumnResizing(), 'show-column-reorder-cursor': columnReorder }; const headerGroups: HeaderGroup[] = getHeaderGroups(); - const rowActionsLength = Math.min(Math.max(rowActions.length * 40, 90), 160); + // const rowActionsLength = Math.min(Math.max(rowActions.length * 40, 90), 160); return ( From fdca828f15cbffe4d086cdf3e3d2e84bd5adcd4e Mon Sep 17 00:00:00 2001 From: Venkatesh N Date: Thu, 11 Jan 2024 15:01:37 +0530 Subject: [PATCH 3/3] Fixed css lint issue --- stencil-workspace/src/components/modus-table/modus-table.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stencil-workspace/src/components/modus-table/modus-table.scss b/stencil-workspace/src/components/modus-table/modus-table.scss index f94113ed9..b83b5d579 100644 --- a/stencil-workspace/src/components/modus-table/modus-table.scss +++ b/stencil-workspace/src/components/modus-table/modus-table.scss @@ -30,8 +30,8 @@ table { font-family: $primary-font; font-size: $rem-14px; height: fit-content; - width: 100%; table-layout: fixed; + width: 100%; &.cell-borderless { th,