Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's not always clear the some results are paginated. #383

Open
dopry opened this issue Feb 7, 2024 · 1 comment
Open

It's not always clear the some results are paginated. #383

dopry opened this issue Feb 7, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Up for grabs for the community. Probably not a "good first issue", unless labelled as such too

Comments

@dopry
Copy link
Collaborator

dopry commented Feb 7, 2024

When querying sites { pages {} } grapple enforces a hard limit on the number of responses returned. When you get a response there is not indication that there are more pages to be fetched or that there was a default limit applied. I feel like we should update these interfaces to have some indication of total count, etc.

@zerolab
Copy link
Member

zerolab commented Feb 7, 2024

For ref: https://graphql.org/learn/pagination/, even though it is aimed at cursor pagination. Something like

{
  pages {}
  pagesInfo {
    total: 123
    page: 1,
    hasNextPage: true,
    perPage: 20
  }
}
``

@zerolab zerolab added help wanted Up for grabs for the community. Probably not a "good first issue", unless labelled as such too good first issue Good for newcomers labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Up for grabs for the community. Probably not a "good first issue", unless labelled as such too
Projects
None yet
Development

No branches or pull requests

2 participants