Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie expiry #36

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Cookie expiry #36

merged 2 commits into from
Jul 19, 2021

Conversation

kaedroho
Copy link
Collaborator

@kaedroho kaedroho commented Jul 15, 2021 •
edited
Loading

This PR fixes a couple of issues

  • There wasn't a cookie expiry, so the cookie would delete itself whenever the user restarts their browser
  • If the cookie was deleted/expired, it would append the goal again to the abtesting-goals in local storage, which led to it calling the "goal reached" API multiple times when the user reached the goal page and they would be counted multiple times

kaedroho added 2 commits July 15, 2021 16:25
@kaedroho
Set expiry date on cookie
5a685a4
@kaedroho
Check if user is participant through local storage rather than cookie
cfff165 
This prevents the user from being double counted if they've cleaned out
their cookies and visted the page under test again
@kaedroho kaedroho requested a review from KalobTaulien July 15, 2021 15:37
@KalobTaulien KalobTaulien merged commit 8097fa8 into main Jul 19, 2021
@KalobTaulien KalobTaulien deleted the cookie-expiry branch July 19, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalobTaulien KalobTaulien KalobTaulien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaedroho @KalobTaulien