Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magisk doesn't flash if data is not decrypted and mounted #6448

Closed
akash07k opened this issue Dec 18, 2022 · 5 comments
Closed

Magisk doesn't flash if data is not decrypted and mounted #6448

akash07k opened this issue Dec 18, 2022 · 5 comments

Comments

@akash07k
Copy link

akash07k commented Dec 18, 2022

I'm using Magisk on my Xiaomi Poco F4 (munch) and facing an issue which I think is the bug of Magisk, and it doesn't seem right.
So, if I boot to recovery and try to flash Magisk, it fails, but if I decrypt and mount the data, then it flashes correctly.
However, what I think is it should not be the case, because even though the data is not decrypted and mounted, Magisk needs to only patch the bootimage and accessing the data partition shouldn't be needed most of the times.
So, any way to workaround this issue and expected fix?
Actually since it is a Virtual A/B device, Magisk doesn't retain after every rom update and we are required to flash it everytime from the scratch.
Patching the bootimage everytime is not much practical solution.

Device: Xiaomi Poco F4 (munch)
Android version: 13.0
Magisk version name: 25.2
Magisk version code: 25205

@AngelofVerdant
Copy link
Contributor

Yea, that sounds like a real hassle mate. Will be picking up my Redmi Note 10 Pro tomorrow to test this. I'm not sure how Android 13 partitions work, could be an Android 13 thing you never know

@cyberboh
Copy link

@akash07k This not about magisk failure, but its about your recovery to be used to flash magisk.
1st- You need recovery that support decryption
2nd- After boot to recovery, insert your PIN/Password/Pattern
3rd - Flash magisk and profit!

Or

Remove any PIN/Password/Pattern before entering recovery , it shouldn't ask for decryption and then flash magisk, profit!

@yujincheng08
Copy link
Collaborator

#3037 (comment)

@yujincheng08 yujincheng08 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 19, 2022
@akash07k
Copy link
Author

You didn't got my point.
Since magisk needs to patch the bootimage only, the data decription should not be required at all.
This is not a recovery issue.

@akash07k This not about magisk failure, but its about your recovery to be used to flash magisk. 1st- You need recovery that support decryption 2nd- After boot to recovery, insert your PIN/Password/Pattern 3rd - Flash magisk and profit!

Or

Remove any PIN/Password/Pattern before entering recovery , it shouldn't ask for decryption and then flash magisk, profit!

@akash07k
Copy link
Author

Thanks buddy, please check and let me know your findings.
Thinking to give Lygisk a try now since this issue is straight away closed. :(

Yea, that sounds like a real hassle mate. Will be picking up my Redmi Note 10 Pro tomorrow to test this. I'm not sure how Android 13 partitions work, could be an Android 13 thing you never know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants