Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magisk 21.1 addon.d fails on LOS 17.1 #3595

Closed
pwn0r opened this issue Dec 22, 2020 · 3 comments
Closed

Magisk 21.1 addon.d fails on LOS 17.1 #3595

pwn0r opened this issue Dec 22, 2020 · 3 comments

Comments

@pwn0r
Copy link

pwn0r commented Dec 22, 2020

Hi, recently this issue has been a bit annoying. There is not really much documentation on addon.d (apparently?) so I cannot really research myself much here.

I have Magisk 21.1 installed on oneplus3 (which is not A/B obviously). I run LOS17.1 and update it quite often. It does appear to work from OTA updater, but here we are talking about dirty flash from TWRP 3.4.0

The sequence as follows, just repeated to double-check this today:

  1. LOS17.1 2020-12-14 installed with Magisk 21.1

  2. Reboot to TWRP, reflash Magisk for confirmation, says addon.d installed. Restart to system. Doublecheck -- that 99-whatever script is in the addond folder. Magisk is installed (actually more reinstalled in this case as it was before. This step only to double-check that magisk is installed properly)

  3. Reboot to TWRP, flash LOS 17.1 2020-12-21 from TWRP. Addon.d fails. If I reboot to system straight away then magisk manager is still there but magisk is not installed.

It would be not much of a problem just to reflash magisk but in my case it apparently breaks configuration for one module and it is very annoying, requires time to redo it.

And before you mention issue #2686 -- nope, not this case. The data is fully decrypted on this device.

@meiser79
Copy link
Contributor

For me, it was #3494 which made it work again.

@topjohnwu
Copy link
Owner

If that PR fixes the issue, then it is already fixed in the latest build

@pwn0r
Copy link
Author

pwn0r commented Dec 29, 2020

thanks, it seems 21.2 has indeed fixed the issue on oneplus3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants