Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Provider CodeBuild projects use permissive role #2

Open
tomwwright opened this issue Aug 31, 2020 · 0 comments
Open

Resource Provider CodeBuild projects use permissive role #2

tomwwright opened this issue Aug 31, 2020 · 0 comments
Labels
module/resourceproviders type/debt Technical debt that needs to be addressed in the future

Comments

@tomwwright
Copy link
Owner

The CloudFormation CLI deploys a CloudFormationManagedUploadInfrastructure stack during cfn submit to handle uploading the handlers package. It also deploys a stack for the resource provider's execution role.

To cater for this functionality, the CodeBuild role for deploying a resource provider has an overly permissive policy:

...
- PolicyDocument:
    Version: "2012-10-17"
    Statement:
      - Action:
          - cloudformation:*
          - iam:*
          - kms:*
          - s3:*
        Effect: "Allow"
        Resource: "*"
  PolicyName: CloudFormationManagedUploadInfrastructure
@tomwwright tomwwright added type/debt Technical debt that needs to be addressed in the future module/resourceproviders labels Aug 31, 2020
@tomwwright tomwwright added type/debt Technical debt that needs to be addressed in the future and removed type/debt Technical debt that needs to be addressed in the future labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/resourceproviders type/debt Technical debt that needs to be addressed in the future
Projects
None yet
Development

No branches or pull requests

1 participant