-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add \xHH Unicode escape code to basic strings #796
Conversation
@pradyunsg Where did we land with this? It seems like a friction-free addition to the language (and one that would bring TOML in line with many other languages which also support |
Yea, let's do this. |
@eksortso Do you have time to update this PR against the current |
I'll update it later this evening. |
Awesome, thanks @eksortso |
@marzer I think that's got it. |
The second change to |
For some reason I'd thought this had already been taken care of. It's up to date again. @marzer @pradyunsg Care to take look at it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise!
@pradyunsg Any updates on this? Is the issue with |
Thanks @eksortso! ^>^ |
Per a conversation in #622, this PR adds a two-character \x escape code sequence for the first 256 Unicode code points. This provides a short explicit sequence for, among other code points: ASCII characters, certain control characters, and whitespace characters such as tab (\x09) and space (\x20) that need visible representation without resorting to longer \u and \U codes. Such sequences are commonly found in languages that also support the \u and \U codes for Unicode.
This PR replaces #709 and is intended for a post-v1.0.0 version of the TOML standard.