Make seconds optional in times

[eksortso]

Allows the seconds portion of values with Offset Date-Time, Local Date-Time, and Local Time type to be omitted. Closes #671.

[h-vetinari]

@pradyunsg @mojombo
It's a late candidate for 1.0, but very useful, since so many timestamps in real life do not actually use seconds (and adding ":00" everywhere is unnecessary dead weight for reading/typing). TOML is "a config file format for humans" after all. ;-)

[pradyunsg]

Thanks for filing this PR @eksortso and for the nudge @h-vetinari!

I still think we should defer this to after 1.0; since I don't wan to pile on too many changes to 1.0 from 0.5. There's already been more than I'd have liked but they felt a lot more urgent than this does.

[ChristianSi]

Looks good now!

[h-vetinari]

@pradyunsg: I still think we should defer this to after 1.0; since I don't wan to pile on too many changes to 1.0 from 0.5. There's already been more than I'd have liked but they felt a lot more urgent than this does.

Fair enough. But OTOH, it's a very non-invasive change (optionally removing seconds does not make 0.5-documents invalid), and considering the availability of dev-time (and hence an expected long release cadence), it's something that should IMO be (re-re-)considered. ;-)

[abelbraaksma]

Looks like this needs to be remerged with head to resolve the conflicts. From what I can tell, the changes here are sound. Anything that blocks this from going into main/master?

[RonnyPfannschmidt]

i would guess time constraints on the devs - i'd love to see this one land as well to sort out a mess i have at my hands

[eksortso]

This PR is replaced with #894. If you contributed to this one, please look over the new one and let me know what you think over there.