Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: Performance Improvements to fmt::Layer #428

Open
davidbarsky opened this issue Nov 14, 2019 · 3 comments · May be fixed by #2840
Open

subscriber: Performance Improvements to fmt::Layer #428

davidbarsky opened this issue Nov 14, 2019 · 3 comments · May be fixed by #2840
Labels
crate/subscriber Related to the `tracing-subscriber` crate kind/perf Performance improvements

Comments

@davidbarsky
Copy link
Member

(This is followup from #420)

fmt::Layer's performance can probably be improved by pooling allocations of Strings and Extensions. hawkw/natatorium is one possible crate that can be used.

@davidbarsky davidbarsky added crate/subscriber Related to the `tracing-subscriber` crate kind/perf Performance improvements labels Nov 14, 2019
@hawkw
Copy link
Member

hawkw commented Nov 14, 2019

hawkw/natatorium is one possible crate that can be used.

I think a better solution (rather than trying to get the natatorium stuff releasable) would be to add support for pooling to sharded_slab: hawkw/sharded-slab#2

@davidbarsky
Copy link
Member Author

I believe the registry already makes use of some pooling. I'll close this in the meantime.

@davidbarsky
Copy link
Member Author

Whoops, re-opening. The registry does some pooling, but it doesn't pool strings or hashmaps. it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate/subscriber Related to the `tracing-subscriber` crate kind/perf Performance improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants