-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item type of broadcast Stream #3214
Comments
You are correct in that the stream should represent "closed" as returning |
That would certainly be an option. I'm also open to other solutions, but I'm not sure what alternatives there are. |
@Darksonn How do you think we should proceed here? |
I think we should add a new error type. Considering we already have an entire module for errors for broadcast, I do not think that is an issue API-complexity wise, as people probably wont look into that module very much. I also think it would make sense to make the |
We are removing the stream impl in #2870, so I think we can punt on this for now? |
Fair point. |
Is this still relevant and an issue to work on? |
Ah, thanks for reminding me of the issue. No, a new |
The item type of the broadcast
into_stream
Stream isResult<T, RecvError>
, but thatRecvError
has a variant calledClosed
. We should reconsider this, as the stream should just returnNone
in that situation.The text was updated successfully, but these errors were encountered: