Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll: Optimize locks and allocations in the critical path #1701

Open
jasta opened this issue Jul 30, 2023 · 0 comments
Open

poll: Optimize locks and allocations in the critical path #1701

jasta opened this issue Jul 30, 2023 · 0 comments

Comments

@jasta
Copy link
Contributor

jasta commented Jul 30, 2023

The poll implementation in #1687 makes liberal use of locks and allocations in closed_raw_fds and pending_removal in fairly hot code paths that can be optimized away. There are some dead lock and efficiency concerns as identified here: #1687 (comment) and #1687 (comment) .

These optimizations may prove significant but can be punted until we get the code stable and proven to work well in a variety of environments. Further, it'd be nice to have some new tests that make sure we don't regress by optimizing the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant