You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The poll implementation in #1687 makes liberal use of locks and allocations in closed_raw_fds and pending_removal in fairly hot code paths that can be optimized away. There are some dead lock and efficiency concerns as identified here: #1687 (comment) and #1687 (comment) .
These optimizations may prove significant but can be punted until we get the code stable and proven to work well in a variety of environments. Further, it'd be nice to have some new tests that make sure we don't regress by optimizing the code.
The text was updated successfully, but these errors were encountered:
The poll implementation in #1687 makes liberal use of locks and allocations in
closed_raw_fds
andpending_removal
in fairly hot code paths that can be optimized away. There are some dead lock and efficiency concerns as identified here: #1687 (comment) and #1687 (comment) .These optimizations may prove significant but can be punted until we get the code stable and proven to work well in a variety of environments. Further, it'd be nice to have some new tests that make sure we don't regress by optimizing the code.
The text was updated successfully, but these errors were encountered: