Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Franklin websites fail to being parsed by openring #1083

Open
indymnv opened this issue Mar 14, 2024 · 0 comments
Open

Franklin websites fail to being parsed by openring #1083

indymnv opened this issue Mar 14, 2024 · 0 comments

Comments

@indymnv
Copy link

indymnv commented Mar 14, 2024

openring is a nice tool to create webring, I added it to my Franklin website. However, I noticed that Franklin websites are not able to being parsed by openring, while the ones built with Hugo, Jekylls or Quarto don't have any problem, here is an example for reproducibility (notice you have to install Go):

$>git clone https://git.sr.ht/~sircmpwn/openring
$>cd openring
$>go build openring.go 
$>./openring \
  -s https://bkamins.github.io/feed.xml \
  -s https://jarbus.net/index.xml \
  -s https://www.paltmeyer.com/blog/index.xml \
  < in.html \
  > out.html
2024/03/14 17:59:04 Fetching feeds...
2024/03/14 17:59:05 Fetched Blog by Bogumił Kamiński
2024/03/14 17:59:06 Fetched jarbus.net on
2024/03/14 17:59:08 Fetched Patrick Altmeyer

Everything works just fine with these blogs, but trying with at least one Franklin website like Viralinstruction, The Cedar Ledge, huijzer, or mine fail in the process

$>./openring \
  -s https://bkamins.github.io/feed.xml \
  -s https://jarbus.net/index.xml \
  -s https://viralinstruction.com/feed.xml \
  < in.html \
  > out.html
2024/03/14 18:11:29 Fetching feeds...
2024/03/14 18:11:30 Fetched Blog by Bogumił Kamiński
2024/03/14 18:11:30 Fetched jarbus.net on
2024/03/14 18:11:31 Fetched
        viralinstruction

2024/03/14 18:11:31 failed parsing canonical feed URL of the feed

Leaving the out.html empty as it was in the beginning.

Trying to see the code in openring.go and see where it fails, looks like is having a problem with parsing the links in Franklin websites

feedLink, err := url.Parse(feed.Link)
		log.Println(err) //I just Added to see the err element
		if err != nil {
			log.Fatal("failed parsing canonical feed URL of the feed")
		}

compile and run it again give me this:

$>./openring \
  -s https://bkamins.github.io/feed.xml \
  -s https://jarbus.net/index.xml \
  -s https://viralinstruction.com/feed.xml \
  < in.html \
  > out.html
2024/03/14 18:16:13 Fetching feeds...
2024/03/14 18:16:13 Fetched Blog by Bogumił Kamiński
2024/03/14 18:16:14 Fetched jarbus.net on
2024/03/14 18:16:14 Fetched
        viralinstruction

2024/03/14 18:16:14 <nil>
2024/03/14 18:16:14 <nil>
2024/03/14 18:16:14 parse " https://viralinstruction.com/ ": first path segment in URL cannot contain colon
2024/03/14 18:16:14 failed parsing canonical feed URL of the feed

I am a bit lost where could be the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant