Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go.mod path #13

Closed
wants to merge 2 commits into from
Closed

Fix go.mod path #13

wants to merge 2 commits into from

Conversation

r-n-o
Copy link
Collaborator

@r-n-o r-n-o commented Apr 13, 2023

After #9 was merged and v0.3.4 released we noticed failures to install the latest version of the go package:

$ go install github.com/tkhq/tkcli@latest
go: downloading github.com/tkhq/tkcli v0.3.4
go: github.com/tkhq/tkcli@latest: module github.com/tkhq/tkcli@latest found (v0.3.4), but does not contain package github.com/tkhq/tkcli

Specifying the folder doesn't work either:

$ go install -v github.com/tkhq/tkcli/src@latest
go: github.com/tkhq/tkcli/src@latest: github.com/tkhq/tkcli/[email protected]: parsing go.mod:
	module declares its path as: github.com/tkhq/tkcli
	        but was required as: github.com/tkhq/tkcli/src

This mini-diff should fix the issue!

I tagged/released this as v0.3.5-beta2 and src/v0.3.5-beta2 (yes, prefixed tags...😮‍💨). And it works as far as I can tell:

go install github.com/tkhq/tkcli/[email protected]
go: downloading github.com/tkhq/tkcli v0.3.5-beta2
go: downloading github.com/tkhq/tkcli/src v0.3.5-beta2

@r-n-o r-n-o requested a review from lrvick April 13, 2023 02:39
@r-n-o
Copy link
Collaborator Author

r-n-o commented Apr 13, 2023

Closing this PR. We've decided installing with go install isn't something we want to support long-term. Given turnkey CLI is supposed to be used as a binary, it makes little sense to distribute it that way. We have 3 install options documented in our README, let's stick to those!

@r-n-o r-n-o closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant